Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add songbirdz to web base org #1303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dry-tortuga
Copy link
Contributor

@dry-tortuga dry-tortuga commented Nov 25, 2024

What changed? Why?

Fixed an issue from the previous PR (#1186) at https://songbirdz.cc that was presenting a blank white screen for some users...

Notes to reviewers

How has it been tested?

Tested locally, see the screenshot below:

Screenshot from 2024-12-09 09-14-05

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:53pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:53pm

Copy link

vercel bot commented Nov 25, 2024

@dry-tortuga is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 25, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns
Copy link
Member

wbnns commented Dec 6, 2024

@dry-tortuga

Thanks for adding this! Could you please update the tags from nft to gaming?

@dry-tortuga
Copy link
Contributor Author

@dry-tortuga

Thanks for adding this! Could you please update the tags from nft to gaming?

@wbnns Updated to the new category and subcategory format, and now it's gaming!

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@dry-tortuga Thanks so much!

@wbnns wbnns removed change(s) requested One or more changes have been requested community contribution labels Dec 19, 2024
@wbnns
Copy link
Member

wbnns commented Dec 28, 2024

@dry-tortuga Hello, apologies, looks like this needs to be rebased again to resolve the merge conflict.

@wbnns wbnns added the change(s) requested One or more changes have been requested label Dec 28, 2024
@dry-tortuga
Copy link
Contributor Author

@dry-tortuga Hello, apologies, looks like this needs to be rebased again to resolve the merge conflict.

@wbnns Done!

@dry-tortuga
Copy link
Contributor Author

@wbnns just updated the commit to make sure it's signed, should be good for final review now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants