Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Swedish & Thai translations of "Base is for everyone" on homepage #1290

Merged
merged 4 commits into from
Dec 19, 2024
Merged

chore: add Swedish & Thai translations of "Base is for everyone" on homepage #1290

merged 4 commits into from
Dec 19, 2024

Conversation

asianviking
Copy link
Contributor

What changed? Why?
Add Swedish & Thai translations of "Base is for everyone" on homepage

Notes to reviewers

How has it been tested?

  • Run yarn workspace @app/web dev
  • Navigate to http://localhost:3000 in your browser
  • Make sure the slider is working as expected

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:15am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:15am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 23, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2024

@asianviking is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

derRizzMeister
derRizzMeister approved these changes Nov 23, 2024
View reviewed changes
Copy link

@derRizzMeister derRizzMeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cb-heimdall
Copy link
Collaborator

Review Error for derRizzMeister @ 2024-11-23 14:33:44 UTC
User must have write permissions to review

@wbnns
Copy link
Member

wbnns commented Dec 6, 2024

@asianviking

Hi there! Thanks for contributing to Base! Could you please resolve the merge conflict?

@wbnns wbnns self-assigned this Dec 6, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested community contribution labels Dec 6, 2024
@asianviking
Copy link
Contributor Author

Heya @wbnns ! Conflicts should be resolved now. Ty!

@wbnns wbnns removed their assignment Dec 18, 2024
@wbnns wbnns added base translation review To be reviewed by the Base translation team and removed change(s) requested One or more changes have been requested labels Dec 19, 2024
wbnns
wbnns approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asianviking Ty!

@wbnns wbnns enabled auto-merge (squash) December 19, 2024 21:47
@wbnns wbnns merged commit 5bf5bb3 into base-org:master Dec 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derRizzMeister derRizzMeister derRizzMeister approved these changes

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base translation review To be reviewed by the Base translation team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asianviking @cb-heimdall @wbnns @derRizzMeister