Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Foundry documentation with explicit command parameters #1258

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

donatik27
Copy link

What changed? Why?

  • Replaced placeholder "..." in Foundry commands with explicit parameters (<CONTRACT_NAME>, <CONTRACT_ADDRESS>)
  • Makes documentation more clear and prevents confusion about required command parameters
  • Helps developers understand exactly what values they need to provide

Notes to reviewers

  • No functional changes
  • Only documentation clarity improvements
  • All URLs, chain IDs and other technical details remain unchanged
  • Follows standard documentation practices for command-line examples

How has it been tested?

  • Verified all links still work
  • Confirmed command syntax matches official Foundry documentation
  • Checked that all original information is preserved

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 6:52pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 6:52pm

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Nov 15, 2024

@donatik27 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@donatik27
Copy link
Author

@cb-heimdall

@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2024-12-02 14:57:08 UTC
User failed mfa authentication, see go/mfa-help

@donatik27
Copy link
Author

@ericbrown99

@cb-heimdall
Copy link
Collaborator

Review Error for ericbrown99 @ 2024-12-03 18:47:04 UTC
User failed mfa authentication, see go/mfa-help

@donatik27
Copy link
Author

@cb-heimdall Hi! Is there anything I can help with regarding the MFA authentication? Let me know if you need any assistance with the review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants