Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC20 Token Generator to Base Ecosystem #1245

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add ERC20 Token Generator to Base Ecosystem #1245

wants to merge 18 commits into from

Conversation

vittominacori
Copy link

What changed?

Add ERC20 Token Generator to Base Ecosystem.

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 9:48am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 9:48am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 11, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024

@vittominacori is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

wbnns
wbnns requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vittominacori

Hi there! Thanks for this PR! Could you please update the tag to infra and ensure the landing page points to a specific page relevant to Base users?

@wbnns wbnns self-assigned this Dec 5, 2024
@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related community contribution labels Dec 5, 2024
@vittominacori vittominacori requested a review from wbnns December 8, 2024 21:37
@vittominacori
Copy link
Author

vittominacori commented Dec 18, 2024 •
edited
Loading

@wbnns changes have been applied. Thanks.

@wbnns wbnns removed their assignment Dec 19, 2024
@wbnns
Copy link
Member

wbnns commented Dec 19, 2024 •
edited
Loading

@vittominacori

Hi there! Apologies, we recently updated the way we categorize and subcategorize apps; could you please update your PR, conforming to the new format by removing the tag, and defining the category (infra) and subcategory (developer tool)?

We'll do our best to review as soon as possible once you do! 🙏

@vittominacori
Copy link
Author

@wbnns of course. done.

@vittominacori vittominacori requested a review from wbnns December 27, 2024 15:34
@wbnns
Copy link
Member

wbnns commented Dec 28, 2024

@vittominacori Hello, apologies, looks like this needs to be rebased. Also, please update the link to point to: https://www.smartcontracts.tools/token-generator/create/base/

@vittominacori
Copy link
Author

@vittominacori Hello, apologies, looks like this needs to be rebased. Also, please update the link to point to: https://www.smartcontracts.tools/token-generator/create/base/

@wbnns updated the link again.

I also see other projects pointing to default page (not base related).
From our default url you can simply access base utility clicking on the base logo. Anyway, updated.

@wbnns
Copy link
Member

wbnns commented Dec 29, 2024

@vittominacori

Thank you, could you please rebase and resolve the merge conflict? As to the landing page, this is something that is currently being updated for various external links throughout the codebase. We appreciate your help. 🙏

@vittominacori
Merge branch 'master' of https://github.com/base-org/web into feat/ad…
5c559a4 
…d-token-generator

# Conflicts:
#	apps/web/src/data/ecosystem.json
@vittominacori
Copy link
Author

@wbnns merged. thank you.

@wbnns wbnns added ready for merge Ready for merge, an additional reviewer is needed and removed change(s) requested One or more changes have been requested labels Dec 30, 2024
@vittominacori
Copy link
Author

@wbnns

I'm sorry but this PR was created on nov 11. I cannot understand why this is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related ready for merge Ready for merge, an additional reviewer is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vittominacori @cb-heimdall @wbnns