Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update file path for new NFT contract in description #1048

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

jackchuma
Copy link
Contributor

What changed? Why?

In the deploy-with-foundry tutorial, there's a note saying to add the contract file at the path contracts/NFT.sol. That's incorrect and just needs to be updated to src/NFT.sol (which is where the deploy command later in the tutorial is expecting it to be).

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:45pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:45pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 7, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jackchuma Thanks!

@wbnns wbnns merged commit a16234e into master Oct 8, 2024
8 checks passed
@wbnns wbnns deleted the jack/update-deploy-with-foundry-tutorial branch October 8, 2024 14:54
kirkas pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants