Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bapp 649 polish when previewing frames the frame should be much #1047

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Feature/bapp 649 polish when previewing frames the frame should be much #1047

merged 1 commit into from
Oct 8, 2024

Conversation

JFrankfurt
Copy link
Contributor

before after
image image

@JFrankfurt JFrankfurt requested a review from a team October 7, 2024 20:12
@JFrankfurt JFrankfurt self-assigned this Oct 7, 2024
@linear Linear
Copy link

linear bot commented Oct 7, 2024

BAPP-649 [Polish] When previewing frames, the frame should be much smaller

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:21pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:21pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 7, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@JFrankfurt JFrankfurt marked this pull request as draft October 7, 2024 20:12
@JFrankfurt JFrankfurt force-pushed the feature/bapp-649-polish-when-previewing-frames-the-frame-should-be-much branch from 73099c5 to 4863bc5 Compare October 7, 2024 20:15
@JFrankfurt JFrankfurt marked this pull request as ready for review October 7, 2024 20:15
@JFrankfurt JFrankfurt merged commit fd609a9 into master Oct 8, 2024
8 checks passed
@JFrankfurt JFrankfurt deleted the feature/bapp-649-polish-when-previewing-frames-the-frame-should-be-much branch October 8, 2024 17:01
kirkas pushed a commit that referenced this pull request Oct 21, 2024
@JFrankfurt
force frames to be only as wide as the initial preview frame placehol…
1ca5beb 
…der (#1047)
kirkas pushed a commit that referenced this pull request Oct 21, 2024
@JFrankfurt
force frames to be only as wide as the initial preview frame placehol…
a58b81e 
…der (#1047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendan-defi brendan-defi brendan-defi approved these changes

Assignees

@JFrankfurt JFrankfurt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JFrankfurt @cb-heimdall @brendan-defi