Update logger.ts #1044
Open
Update logger.ts #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@betrayalove is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Context Initialization: Replaced useAnalytics call inside AnalyticsProvider with direct use of useContext to avoid potential context initialization issues when the provider is at the top level. Performance Improvement: Changed toLocaleLowerCase() to toLowerCase() in the logEventWithContext function to avoid unnecessary localization overhead, improving performance. Code Readability: Replaced !!c with Boolean(c) in the context concatenation logic to improve code readability.
kirkas
approved these changes
Oct 7, 2024
|
tyvm @betrayalove appreciate you |
zencephalon
force-pushed
the
master
branch
2 times, most recently
from
e8770ac
to
c05a8df
Compare
|
Hi there! |
wbnns
added
change(s) requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved unnecessary repetitive logging to else block
There is no need to re-log with the same error, either remove it or move it like this.