Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some pr nits #1041

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore: some pr nits #1041

merged 1 commit into from
Oct 4, 2024

Conversation

JFrankfurt
Copy link
Contributor

@dneilroth had a good nit, and I noticed a thing I could clean up in my tests

@JFrankfurt JFrankfurt requested review from dneilroth and a team October 4, 2024 20:55
@JFrankfurt JFrankfurt self-assigned this Oct 4, 2024
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 9:00pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 9:00pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 4, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@JFrankfurt JFrankfurt enabled auto-merge (squash) October 4, 2024 20:56
@JFrankfurt JFrankfurt merged commit 5316dff into master Oct 4, 2024
8 checks passed
@JFrankfurt JFrankfurt deleted the clean-up-ipSafe branch October 4, 2024 21:03
kirkas pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants