check for frame ip safety #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
JFrankfurt
force-pushed
the
feature/bapp-653-create-blocklist-of-ips-we-should-not-resolve-dns-for-in
branch
from
b04fd42
to
702d366
Compare
kirkas
approved these changes
Oct 4, 2024
dneilroth
approved these changes
Oct 4, 2024
| } | ||
|
|
||
| if (!allSafe) { | ||
| return NextResponse.json({ message: 'Forbidden: Unsafe IP' }, { status: 403 }); |
There was a problem hiding this comment.
nit: not 100% sure we want to expose this error msg to the client since it could reveal part of our mitigation strategy to a malicious actor, maybe some more generic "bad request" response is better?
JFrankfurt
deleted the
feature/bapp-653-create-blocklist-of-ips-we-should-not-resolve-dns-for-in
branch
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* check for ip safety * add jest * add gh workflow * middleware->frame calls with dns lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/coinbase/issue/BAPP-653/create-blocklist-of-ips-we-should-not-resolve-dns-for-in-basenames
logic:
apps/web/src/middleware/ipSafe.tscalled via a wrapper on frames.js's default route handlers:
apps/web/app/frames/route.tsx