Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and add args #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mhmd-shadfar
Copy link

Hi,
First, I'd like to thank you for the amazing work you've done on this project. Your code has been incredibly helpful.

This pull request refactors the code to enhance scalability and accelerate future development.

changes:

  1. clean up the code.
  2. create utils.py and add get_background() and create_overlay() which you code but I put it in function so that the code looks much cleaner in the future, if you want to add other functions add them to this file.
  3. put chars and numbers and nimi_numbers in the number_char_config.json file so that the main.py is cleaner and you can edit this JSON file in the future if needed.
  4. add input arguments for output-dir and the number of samples.
  5. edit .gitignore file
  6. edit the readme file

Thank you again for your hard work and dedication to this project!

Best regards,
mohamad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant