Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Sierra: new language (Hungarian) added sucessfully to the System, but can't be selected with Spell Right #76

Closed
andrasna opened this issue Oct 14, 2017 · 7 comments

Comments

@andrasna
Copy link

andrasna commented Oct 14, 2017

Hi,

I am trying to make Spell Right work with Hungarian on macOS Sierra.

  • I have followed the System instructions of adding new languages: I have copied dictionary files (hu_HU.aff, hu_HU.dic) to ~/Library/Spelling.

  • I have confirmed that the language has be added to the System:

    • Hungarian ("Magyar") can be selected in System Preferences / Keyboard / Text
    • Hungarian spellcheck works now with Mail
  • I have tried setting spellright.groupDictionaries to false (just as a guess)

I would like to ask, if you could help find out where the problem lies.

Thanks,
Andras

screen shot 2017-10-14 at 11 43 01 am
screen shot 2017-10-14 at 11 44 42 am

@bartosz-antosik
Copy link
Owner

Hm. MacOS is not my specialty. Looks like the system speller does not list dictionaries installed in the Library path, when asked. Looks like there is a Pull Request for the thing in the library I use there seems to be, however, some reluctance in adding the patch.

Have you tried, despite it is not listed, setting spellright.language to hu_HU or hu-HU?

@andrasna
Copy link
Author

andrasna commented Oct 14, 2017

Yes, I forgot to mention, I have tried setting spellright.language to Magyar, Hungarian, hu_HU and now hu-HU as well, just in case. If I do so, it falls back to spell checking in English.

@bartosz-antosik
Copy link
Owner

I have got no time so far to see what can be done about it in the extension itself, but here is another confirmation that what you report is a bug of NNSpellChecker on macOS.

@bartosz-antosik
Copy link
Owner

I have finally managed to have a deeper look into the issue and it seems that this is a bug of NSSpellChecker which does not allow to list/use the spelling dictionaries installed in the Library folder. Possibly this patch could serve as workaround for the issue but it requires installing binary dependence of nodobjc which installs only on macOS.

This would require help of someone on macOS with some JavaScript and node.js experience.

I will make appropriate notice in README and until someone helps a bit Spell Right will not be able to spell in Library Installed language.

Side question: Is your macOS purchased in Hungary? I had hazy impression that macOS provides spelling dictionaries for the market it is sold on?

@andrasna
Copy link
Author

Thanks, I probably have to look into this a bit myself, to see how I could be of help.

Yes, it is purchased in Hungary, oddly enough, with Hungarian keyboard.

@bartosz-antosik
Copy link
Owner

If you could maybe help then first step would be to test if you can install NodObjC node.js module, e.g.:

npm install nodobjc

Then application of the patch should be doable. Then it could be tested whether node-spellchecker works with setting hu_HU as language.

It would then in turn open some way to think how to do this inside Spell Right.

Still I am not sure whether this can be done as node-spellchecker maintainers have not integrated the patch so maybe there is some catch.

bartosz-antosik pushed a commit that referenced this issue Oct 16, 2017
@martinboksa
Copy link

Any new update, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants