Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mean instead of sum #66

Closed
2 tasks
fruce-ki opened this issue Mar 18, 2019 · 0 comments
Closed
2 tasks

Mean instead of sum #66

fruce-ki opened this issue Mar 18, 2019 · 0 comments
Assignees
@fruce-ki
Labels
enhancement Suggestions for better performance or better presentation.
Milestone
0.7.0

Comments

@fruce-ki
Copy link
Collaborator

fruce-ki commented Mar 18, 2019 •
edited
Loading

Currently, replicate samples are summed before comparison with G-test. This results in larger counts and increased sensitivity. Using the mean instead could reduce FPs from low-count transcripts.

  • Benchmark the mean.
  • Make it an option, default to whichever seems best in the benchmark.
@fruce-ki fruce-ki added the enhancement Suggestions for better performance or better presentation. label Mar 18, 2019
@fruce-ki fruce-ki self-assigned this Mar 18, 2019
@fruce-ki fruce-ki added this to the 0.7.0 milestone Mar 18, 2019
@fruce-ki fruce-ki added the in progress Issue is actively being addressed label Jul 10, 2019
fruce-ki added a commit that referenced this issue Jul 11, 2019
@fruce-ki
Implements #66
04c1547 
Going forward, mean is the default behaviour. User can choose to use sum instead, as in the old behaviour.
@fruce-ki fruce-ki removed the in progress Issue is actively being addressed label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fruce-ki fruce-ki

Labels
enhancement Suggestions for better performance or better presentation.
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@fruce-ki