Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N/A DTU inflating TRUE DTU #36

Closed
fruce-ki opened this issue Oct 10, 2017 · 1 comment
Closed

N/A DTU inflating TRUE DTU #36

fruce-ki opened this issue Oct 10, 2017 · 1 comment
Assignees
Labels
bug RATs not behaving the way it is intended to. enhancement Suggestions for better performance or better presentation.
Milestone

Comments

@fruce-ki
Copy link
Collaborator

fruce-ki commented Oct 10, 2017

While I'd like to keep NA values (aka ineligible feature) separate from genuine FALSE values (tested and did not pass), this causes considerable typing overhead for subsetting the tables by DTU and is an easy and recurrent source of errors in analysis of the results.
Subsetting a table by a vector (logical or keys) always also returns lines that are NA for the criterion. In order to only subset the rows with TRUE values, the criterion must include !is.na(). This behaviour affects all the logical fields, not just DTU.

Based on how many times I've been caught out by this bug/feature of tables/R, I think RATs should do a final pass over the results and replace all NA values in the flag fields with explicit FALSE. Ina sense, items not eligible for testing, automatically are not DTU, so this is not too much of a stretch and it should make downstream analysis safer and easier.

@fruce-ki fruce-ki added bug RATs not behaving the way it is intended to. enhancement Suggestions for better performance or better presentation. labels Oct 10, 2017
@fruce-ki fruce-ki self-assigned this Oct 10, 2017
@fruce-ki fruce-ki added the urgent Requires immediate resolution. label Oct 10, 2017
@fruce-ki fruce-ki changed the title N/A DTU N/A DTU inflating TRUE DTU Oct 19, 2017
@fruce-ki fruce-ki added this to the 0.6.1 milestone Oct 19, 2017
fruce-ki added a commit that referenced this issue Jan 5, 2018
all flags will be either TRUE or FALSE. NAs converted to FALSE.
DTU false includes elig false.
tests updated accordingly.
@fruce-ki
Copy link
Collaborator Author

fruce-ki commented Jan 5, 2018

All flag values are now either TRUE or FALSE.
DTU==FALSE now includes the cases where elig==FALSE, which are not tested and have NA test results. This is not too much of a stretch. Transcripts with too low abundance (including those not expressed) would not be considered reliable DTU even if tested, while genes with just one known transcript isoform certainly cannot show DTU.

This makes subsetting of the results simpler and more intuitive and prevents sneaky errors.

@fruce-ki fruce-ki closed this as completed Jan 5, 2018
@fruce-ki fruce-ki mentioned this issue Feb 15, 2018
@fruce-ki fruce-ki removed the urgent Requires immediate resolution. label May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug RATs not behaving the way it is intended to. enhancement Suggestions for better performance or better presentation.
Projects
None yet
Development

No branches or pull requests

1 participant