Skip to content

Commit

Permalink
Change from 'non-fully' to 'minimally TriBITS Compliant External Pack…
Browse files Browse the repository at this point in the history
…ages' (TriBITSPub#63)

After some more thought, the term "minimally" seems to be a better adjective
and it sounds better than "non-fully".
  • Loading branch information
bartlettroscoe committed Jun 27, 2023
1 parent 0866074 commit 13be36f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ that satisfies the following properties:
* Calls ``find_dependency()`` or the equivalent for all upstream packages that
it depends on.
* Every upstream dependent package ``<UpstreamTpl>`` has the target
``<UpstreamTpl>::all_libs``. (But a non-fully TriBITS-compliant external
``<UpstreamTpl>::all_libs``. (But a minimally TriBITS-compliant external
package need not define this for all of its upstream dependencies.)

That means that when calling ``find_package()`` for a fully TriBITS-compliant
Expand Down
2 changes: 1 addition & 1 deletion tribits/doc/build_ref/TribitsBuildReferenceBody.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1996,7 +1996,7 @@ external packages has several consequences:
* The definition of any TriBITS external packages/TPLs that are enabled
upstream dependencies from any of these external packages should be defined
automatically and will **not** be found again. (But there can be exceptions
for non-fully TriBITS-compliant external packages; see the section
for minimally TriBITS-compliant external packages; see the section
"TriBITS-Compliant External Packages" in the "TriBITS Users Guide".)

The logic for treating internally defined packages as external packages will
Expand Down
14 changes: 7 additions & 7 deletions tribits/doc/guides/TribitsGuidesBody.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2728,13 +2728,13 @@ The requirements for **TriBITS-compliant external packages** are:

NOTE: TriBITS-compliant external packages that provide TriBITS-compliant
external packages for all of their upstream dependencies are said to be *fully
TriBITS-compliant external packages* while those that don't are said to be
*non-fully TriBITS-compliant external packages*. The TriBITS external
package/TPL system is robust enough to deal with non-fully TriBITS-compliant
external packages. Any TriBITS external packages/TPLs upstream from a
non-fully TriBITS-compliant external package will be found again in the
current TriBITS project. (In these cases, it is up to the user to make sure
that the same upstream packages are found.)
TriBITS-compliant external packages* while those that support the minimal
requirements are said to be *minimally TriBITS-compliant external packages*.
The TriBITS external package/TPL system is robust enough to deal with
minimally TriBITS-compliant external packages. Any TriBITS external
packages/TPLs upstream from a minimally TriBITS-compliant external package
will be found again in the current TriBITS project. (In these cases, it is up
to the user to make sure that the same upstream packages are found.)


Example TriBITS Projects
Expand Down

0 comments on commit 13be36f

Please sign in to comment.