Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem where fetched and cached images could not be resized by allowing file caches to use file name suffixes #2269

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

bartfeenstra
Copy link
Owner

No description provided.

… allowing file caches to use file name suffixes
@bartfeenstra bartfeenstra added bug Something isn't working python Pull requests that update Python code labels Jan 19, 2025
@bartfeenstra bartfeenstra added this to the 0.4.x milestone Jan 19, 2025
@bartfeenstra bartfeenstra marked this pull request as ready for review January 19, 2025 14:15
@bartfeenstra bartfeenstra merged commit 3ea0daa into 0.4.x Jan 19, 2025
6 checks passed
@bartfeenstra bartfeenstra deleted the file-cache-suffix branch January 19, 2025 14:24
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.19%. Comparing base (4c4f73d) to head (8d0cf40).
Report is 1 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/cache/file.py 83.33% 2 Missing and 1 partial ⚠️
betty/cache/_base.py 84.61% 2 Missing ⚠️
betty/fetch/http.py 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #2269      +/-   ##
==========================================
- Coverage   98.22%   98.19%   -0.03%     
==========================================
  Files         365      365              
  Lines       23227    23244      +17     
  Branches     1075     1077       +2     
==========================================
+ Hits        22814    22824      +10     
- Misses        263      268       +5     
- Partials      150      152       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant