Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the Nginx extension #1055

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Reintroduce the Nginx extension #1055

merged 1 commit into from
Dec 20, 2023

Conversation

bartfeenstra
Copy link
Owner

No description provided.

@bartfeenstra bartfeenstra added the enhancement New feature or request label Dec 19, 2023
@bartfeenstra bartfeenstra added this to the 0.3.0 milestone Dec 19, 2023
Copy link

🍎 Uploaded betty.app.zip for commit b9e1ff3. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🪟 Uploaded betty.exe.zip for commit b9e1ff3. You can download it, test it on Windows, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🍎 Uploaded betty.app.zip for commit b3e99c4. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🍎 Uploaded betty.app.zip for commit 785f6b7. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🍎 Uploaded betty.app.zip for commit 532891d. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🪟 Uploaded betty.exe.zip for commit 532891d. You can download it, test it on Windows, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🍎 Uploaded betty.app.zip for commit b193467. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (17ff4c2) 93.31% compared to head (716d146) 92.58%.

Files Patch % Lines
betty/extension/nginx/__init__.py 56.25% 56 Missing ⚠️
betty/extension/nginx/serve.py 85.71% 7 Missing ⚠️
betty/cli.py 33.33% 4 Missing ⚠️
betty/extension/demo/__init__.py 90.00% 2 Missing ⚠️
betty/extension/nginx/docker.py 94.44% 2 Missing ⚠️
betty/error.py 66.66% 1 Missing ⚠️
betty/serde/error.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1055      +/-   ##
==========================================
- Coverage   93.31%   92.58%   -0.73%     
==========================================
  Files          70       74       +4     
  Lines        8197     8446     +249     
==========================================
+ Hits         7649     7820     +171     
- Misses        548      626      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🪟 Uploaded betty.exe.zip for commit b193467. You can download it, test it on Windows, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

@bartfeenstra bartfeenstra force-pushed the reintroduce-nginx branch 2 times, most recently from cddb87e to eb2cbf0 Compare December 20, 2023 12:02
Copy link

🍎 Uploaded betty.app.zip for commit 884021e. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🪟 Uploaded betty.exe.zip for commit 884021e. You can download it, test it on Windows, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🍎 Uploaded betty.app.zip for commit 9c09fe8. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

@bartfeenstra bartfeenstra force-pushed the reintroduce-nginx branch 3 times, most recently from f4492ef to 64a1085 Compare December 20, 2023 13:38
Copy link

🍎 Uploaded betty.app.zip for commit 191b084. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

@bartfeenstra bartfeenstra merged commit 97a5104 into 0.3.x Dec 20, 2023
5 of 9 checks passed
@bartfeenstra bartfeenstra deleted the reintroduce-nginx branch December 20, 2023 14:31
Copy link

🍎 Uploaded betty.app.zip for commit 97a5104. You can download it, test it on Mac OS, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Copy link

🪟 Uploaded betty.exe.zip for commit 97a5104. You can download it, test it on Windows, and post your feedback in a comment to this pull request 💕

The download will disappear once this pull request is merged, or when it is being rebuilt after a new commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant