Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bufferBlocksCodeGen.js #124

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

cymplecy
Copy link
Collaborator

use value === " " instead of value == " " Because if value being tested is numeric then it passes the value == " " test instead of failing
Re-submitting same PR as previous one

use === instead of == to test for " "
@cymplecy
Copy link
Collaborator Author

I panicked because I thought the PR was wrong
But it just turned out that I'd made a silly mistake in my actual Blockly MQTT code :)

But I panicked and closed the original PR before I'd worked out what had gone wrong :)

@bartbutenaers bartbutenaers merged commit a2b712c into bartbutenaers:master Jan 29, 2024
@cymplecy cymplecy deleted the bufferFix branch January 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants