Remove offical support for Lumen #1425
Conversation
|
Note: static analysis test problem is unrelated and something else |
I'm proposing to drop official suport for Lumen for the following reasons: - Lumen itself is dead, per [1] > **Note:** In the years since releasing Lumen, PHP has made a variety of wonderful performance improvements. For this reason, along with the availability of [Laravel Octane](https://laravel.com/docs/octane), we no longer recommend that you begin new projects with Lumen. Instead, we recommend always beginning new projects with [Laravel](https://laravel.com). Laravel Octact is just Laravel and no one using ide-helper with it needs anything special. - For now, the change is mostly on the logistics side (readme, run tests, issues). In the past we had some special code but over time this was already removed. For now people still can use it and nothing will break out of the blue, but eventually it might There are a only a few Lumen related issues open currently which would be closed by this (barryvdh#1105, barryvdh#1069, barryvdh#438). [1] laravel/lumen@69b2657
|
@barryvdh WDYT? |
|
I guess we could, but do we actually make any changes for Lumen? It's still about 5% of the downloads of Laravel itself. I would suggest we drop it if we actually run into problems. |
That's the thing, people have reported various issues over time because the integration is not straight forward and requires hacks/workarounds. We currently have no in-code hacks (AFAIK) but also it doesn't work out of the box. No matter the graphs, they don't correlate with laravel-ide-helper anyway. We don't PREVENT them to make it work, but I think it's time to make a stance and acknowledge:
Technically, except merging the PR, we won't do anything. We will not prevent it from working. But if we make a change in the spirit Laravel and it breaks Lumen (even more), we make it clear we don't support it. Does that make (more) sense? 🤔 |
|
Yeah I guess |
I'm proposing to drop official suport for Lumen for the following reasons: - Lumen itself is dead, per [1] > **Note:** In the years since releasing Lumen, PHP has made a variety of wonderful performance improvements. For this reason, along with the availability of [Laravel Octane](https://laravel.com/docs/octane), we no longer recommend that you begin new projects with Lumen. Instead, we recommend always beginning new projects with [Laravel](https://laravel.com). Laravel Octact is just Laravel and no one using ide-helper with it needs anything special. - For now, the change is mostly on the logistics side (readme, run tests, issues). In the past we had some special code but over time this was already removed. For now people still can use it and nothing will break out of the blue, but eventually it might There are a only a few Lumen related issues open currently which would be closed by this (barryvdh#1105, barryvdh#1069, barryvdh#438). [1] laravel/lumen@69b2657 Co-authored-by: Barry vd. Heuvel <[email protected]>
Summary
I'm proposing to drop official support for Lumen for the following reasons:
Lumen itself is dead, per [1]
Laravel Octact is just Laravel and no one using ide-helper with it needs anything special.
For now, the change is mostly on the logistics side (readme, run tests, issues). In the past we had some special code but over time this was already removed. For now people still can use it and nothing will break out of the blue, but eventually it might
There are a only a few Lumen related issues open currently which would be closed by this (#1105, #1069, #438). We would also reduce e-waste cycles on the integration test suite matrix.
[1] laravel/lumen@69b2657
Type of change
(note: for now only "on paper", not technically)
Checklist
composer fix-style