Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Laravel 10 (+ update testing matrix) #1407

Merged
merged 8 commits into from
Feb 4, 2023
Merged

Added support for Laravel 10 (+ update testing matrix) #1407

merged 8 commits into from
Feb 4, 2023

Conversation

alies-dev
Copy link
Contributor

@alies-dev alies-dev commented Jan 21, 2023

Summary

Add support with updated testing matrix, also run tests on PHP 8.2.
A number of combinations in matrix is pretty high, I think with the release of Laravel 10 it's a time to drop Laravel 8 support (and thus, PHP 7.3 and PHP 7.4 that are also out of support)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

Why this PR: we need this package to support Laravel 10 as this is a dependency of our another package where I'm a collaborator: https://github.com/psalm/psalm-plugin-laravel. Current package blocks us to improve Laravel 10 support.

@alies-dev alies-dev changed the title Added support for Laravel 10 Added support for Laravel 10 (+ update testing matrix) Jan 21, 2023
@barryvdh
Copy link
Owner

Already merged #1406 but that doesn't have the integration tests yet.

@barryvdh
Copy link
Owner

<8.1 still needs to be excluded from the matrix.

@alies-dev
Copy link
Contributor Author

@barryvdh
Just fixed another case: c259249

@barryvdh barryvdh merged commit ce24d4b into barryvdh:master Feb 4, 2023
@barryvdh
Copy link
Owner

barryvdh commented Feb 4, 2023

Yeah all green, thanks!

@alies-dev alies-dev deleted the laravel-10 branch February 4, 2023 15:00
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* Laravel 10 support

* Add events v10 to suggestions

* Exclude invalid combinations from testing matrix, test on PHP 8.2

* Update CHANGELOG.md

* Use laravel/laravel dev-master as 10.x version

* Exclude one more laravel-php combination

* Use 10.* instead if dev-master

* Update run-integration-tests.yml

---------

Co-authored-by: Barry vd. Heuvel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants