-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Laravel 10 (+ update testing matrix) #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alies-dev
changed the title
Added support for Laravel 10
Added support for Laravel 10 (+ update testing matrix)
Jan 21, 2023
barryvdh
approved these changes
Jan 22, 2023
Already merged #1406 but that doesn't have the integration tests yet. |
<8.1 still needs to be excluded from the matrix. |
Yeah all green, thanks! |
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Laravel 10 support * Add events v10 to suggestions * Exclude invalid combinations from testing matrix, test on PHP 8.2 * Update CHANGELOG.md * Use laravel/laravel dev-master as 10.x version * Exclude one more laravel-php combination * Use 10.* instead if dev-master * Update run-integration-tests.yml --------- Co-authored-by: Barry vd. Heuvel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support with updated testing matrix, also run tests on PHP 8.2.
A number of combinations in matrix is pretty high, I think with the release of Laravel 10 it's a time to drop Laravel 8 support (and thus, PHP 7.3 and PHP 7.4 that are also out of support)
Type of change
Checklist
composer fix-style
Why this PR: we need this package to support Laravel 10 as this is a dependency of our another package where I'm a collaborator: https://github.com/psalm/psalm-plugin-laravel. Current package blocks us to improve Laravel 10 support.