Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Carbon serialization options #1324

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Add support for Carbon serialization options #1324

merged 4 commits into from
Mar 4, 2022

Conversation

FLeudts
Copy link
Contributor

@FLeudts FLeudts commented Feb 28, 2022

Summary

Add support for the serialization options for Carbon instances. Adds tests. Resolves #1322

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-requested a review March 1, 2022 15:34
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FLeudts LGTM, can you add a changelog entry please?

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barryvdh LGTM!

@barryvdh barryvdh merged commit 6041681 into barryvdh:master Mar 4, 2022
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* Add Carbon serialization option handling

* Tests Added

* Add changelog

* Spellcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date and datetime casting is not always recognized
3 participants