Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace composer with copy of classmap generator #1313

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Conversation

barryvdh
Copy link
Owner

@barryvdh barryvdh commented Feb 8, 2022

This replaces the dependency on composer/composer and just uses the copy of the classmap generator (slightly modified).

@barryvdh barryvdh requested a review from mfn February 8, 2022 19:19
@barryvdh barryvdh merged commit 3b03e40 into master Feb 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat-classmap branch February 8, 2022 19:20
@barryvdh
Copy link
Owner Author

barryvdh commented Feb 8, 2022

I'm merging this already because of a conflict with Composer and Laravel 9.

@mfn
Copy link
Collaborator

mfn commented Feb 9, 2022

TBH, glad we got rid of the composer/composer dependency, LGTM 👍🏼

(not perfect to copy paste, but 🤷🏼 )

@barryvdh
Copy link
Owner Author

barryvdh commented Feb 9, 2022

No indeed. See composer/composer#10527 for future plans :)

d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
* Replace composer with copy of classmap generator

* composer fix-style

* Remove phpcleaner

* composer fix-style

* Use filecleaner copy

* composer fix-style

Co-authored-by: laravel-ide-helper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants