Alias will grab macros from \Illuminate\Database\Eloquent\Builder too
#1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturn Eloquent Builder instance.
|
@LastDragon-ru is it possible to have a test, showing the effect of this change? |
|
@mfn, yep, I added a few tests. |
barryvdh
approved these changes
Dec 21, 2020
mfn
approved these changes
Dec 21, 2020
bytestream
pushed a commit
to bytestream/laravel-ide-helper
that referenced
this pull request
Apr 20, 2021
… too (barryvdh#1118) * `Alias` will grab macros from `\Illuminate\Database\Eloquent\Builder` too. * `@return` will contains `|static` for Eloquent Builder macros which return Eloquent Builder instance. * `Macro` tests. * `Alias::detectMethods()` tests. * Mock classes rename. (cherry picked from commit 36c4406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
\Illuminate\Database\Eloquent\Builderis alsoMacroablebut doesn't use the standardMacroabletrait and for this reason, its macros are not included inhelper.php. This PR fixes it.Fixes: #1070
Type of change
Checklist