[PHP8] Add initial compatibility #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The composer.json constraint is unbound, so it's already "allowed" at least.
- not necessary anyway - not compatible with PHP8 currently
This is the minimum version also supporting PHP8
Some lower version requirements like doctrone/dbal won't work and would require at least dbal 2.12.0, which in turn doesn't support PHP 7.2 anymore. So instead of bumping dbal and excluding PHP 7.2 users, we ignore the lowest version for PHP 8 for the time being.
mfn
commented
Dec 3, 2020
| @@ -424,7 +424,7 @@ protected function getPropertiesFromTable($model) | |||
|
|
|||
| $database = null; | |||
| if (strpos($table, '.')) { | |||
| list($database, $table) = explode('.', $table); | |||
| [$database, $table] = explode('.', $table); | |||
There was a problem hiding this comment.
Unrelated but Phpstorm just insists in changed it 💥
This was referenced Dec 3, 2020
Closed
This was referenced Dec 4, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ReflectionParameter->getClass()was called->getType()GeneratePhpdocWithFqn)Same was already done for vimeo/psalm in the past
figured the bump is fine as it's a dev dependency only anyway
^4for PHP8 compat, so it's addedifcondition toDynamicRelations/Test.phpThe biggest issue though is that doctrine/dbal with
prefer-lowestin the test matrix is NOT compatible with PHP8, it throws some method declaration mismatch exception.=> therefore I decided to not bump doctrine/dbal in this PR and just don't run the unit test matrix on PHP8 with prefer-lowest until we've a better solution.
I wonder though why this wouldn't be handled by composer dependency resolution correctly, IDK TBH.
Links
Type of change
Checklist
composer fix-style