allow model_locations to have glob patterns

[isaackearl]

This if statement check for a valid directory was happening to early. It was checking the string that contained the wildcards to see if it is a valid directory and always failing. Need to check after the foreach starts. fixes #1058 .

Summary

Glob patterns currently don't work. The if statement that checks if the path is a directory happens before the glob helper call.

Type of change

• Bug fix (non-breaking change which fixes an issue)

[mfn]

Thanks, LGTM!

---

Would you be up for a test for this?

[isaackearl]

Thanks @mfn .. I think I could be up for a test tomorrow or the next day. To be honest I've been on a rampage tonight trying to get some things working and it's now 5 AM. :)

[mfn]

it's now 5 AM. :)

💥

But yes, I've heard of that. Humans need 💤 and such 😏

[mfn]

Github Actions seems to hang, but nothing on https://www.githubstatus.com/

[isaackearl]

@mfn is there a way to force the checks to re-run? Seems strange that they hung.

[isaackearl]

@mfn I wrote a test, but may need some feedback about where I put it etc. I tried to follow the pattern of the other tests.

[isaackearl]

@mfn So I'll probably need some help finishing this test. It works for me locally when I run using various php versions, however when I run it included with all the rest of the tests, it fails asserting that 'Written new phpDocBlock to' is there. In other words: run the test by itself 👍 ... run the test with all the rest of them 👎 .

[mfn]

Sure, I'll take a look over the weekend!

I'll try and see if I can re-start the tests by closing/opening the PR.

[mfn]

. It works for me locally when I run using various php versions, however when I run it included with all the rest of the tests

I don't know how it even worked for you, as the test neither in isolation nor together with the whole suite worked for me, simply because the "current working directory" as not the one expected.

I pushed a fix (and updated the changelog), all green now.

Are you using windows? Locally I use OSX and the GHA is using Linux, and they behaved the same.

[isaackearl]

@mfn
I'm on Mac os x as well. Now that I'm seeing your changes I have no idea how this is STILL working for me locally when I run the test individually. I am running my tests through php storm.

I'm on php 7.4.9 installed via homebrew.

Regardless, I appreciate you updating it and making it truly work.

[mfn]

ok, great and thanks; also using phpstorm here 😏

Just wanted to make sure there's no bug hidden, but PR LGTM too.

@barryvdh IMHO this is good to merge!

[NickSdot]

Tested. Works here as expected. Thanks!

[mfn]

@NickSdot thanks for the feedback 👍