Fix compatibility with Lumen

[mfn]

Summary

Fixes #1042

Got broken by #1026

TL;DR: can't use anything in the Illuminate\Foundation namespace
without safety check, as it doesn't exist in Lumen.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

• Existing tests have been adapted and/or new tests have been added
• Add a CHANGELOG.md entry
• Update the README.md
• Code style has been fixed via composer fix-style

[mfn]

the static analysis stuff can be ignored, will be fixed in another PR

[mfn]

the static analysis stuff can be ignored, will be fixed in another PR

=> #1044

[DannyvdSluijs]

LGTM. IMHO a small helper function isLaravel(): bool might be a nice improvement which would provide the context the comment is now doing.

[mfn]

LGTM. IMHO a small helper function isLaravel(): bool might be a nice improvement which would provide the context the comment is now doing.

Thanks, added!

[pataar]

Tested this, and it seems to work. 😄

[mfn]

@pataar thanks for confirming

[mfn]

ping @barryvdh IMHO this is good to merge (at least, it's the best idea I could come up with, maybe you have a better one 😬)

[barryvdh]

Hah sorry, to be honest I feel like the helper is a bit overkill in this case.
But I can't remember what this PhpEngine is for. It seems hacky, so I'd rather fix it at the core. Why can't we use the normal view engine? I'm guessing there was a reason but not sure what.

[mfn]

Why can't we use the normal view engine?

Yeah about that 😅

• Apparently some use a custom template engine (e.g. twig) which remove the support for PHP templates in Laravel
• This library though requires PHP templates, as it's how all the commands generate the PHP stub source code
• And then there are users of this library who override the PHP templates with their own extensions, so getting rid of PHP templates altogether can break their flow

It's kind of a catch-22