Bump Laravel versions #1022
Merged
Bump Laravel versions #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YES |
|
Wel technically 5.5 is still supported for two days :P https://laravel.com/docs/7.x/releases |
|
Hmm so dependencies are all good, but not sure why it's failing 1 test. |
The test I don't know this code part how relevant this is (remove test? make a condition to check between L7/L8? 🤷♀️) |
|
Yeah nog sure, maybe update for Laravel 8 and skip the rest? |
|
Alright, like this then? |
mfn
approved these changes
Aug 28, 2020
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class ExampleTest extends TestCase | ||
| class MethodTest extends TestCase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's drop old Laravel versions and start testing Laravel 8