Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDefaultValue fails on variadic params #287

Closed
miraage opened this issue Dec 5, 2015 · 3 comments
Closed

getDefaultValue fails on variadic params #287

miraage opened this issue Dec 5, 2015 · 3 comments

Comments

@miraage
Copy link
Contributor

miraage commented Dec 5, 2015

https://github.com/barryvdh/laravel-ide-helper/blob/v2.1.0/src/Console/ModelsCommand.php#L533

Here should be a check for $param->isDefaultValueAvailable() before $param->getDefaultValue().
@barryvdh
Copy link
Owner

barryvdh commented Dec 5, 2015

Can you submit a PR?

@miraage
Copy link
Contributor Author

miraage commented Dec 5, 2015

I think I could.

@miraage miraage mentioned this issue Dec 6, 2015
Merged
@miraage
Copy link
Contributor Author

miraage commented Dec 7, 2015

Since PR has been merged issue is resolved.

@miraage miraage closed this as completed Dec 7, 2015
barryvdh added a commit that referenced this issue Dec 21, 2015
@barryvdh
Fix meta for 5.2 seeder
d82e8f1 
Fixes #287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miraage @barryvdh