Add try/catch for the substituteBindings #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tpetry any ideas about this? I see you replied to laravel/telescope#1489 also |
|
The change looks good and I would have suggested the same. I've heard that the escaping logic sometimes fails but no one ever came up with an example. Its always reports like the Telescope one that there is one problem, but instead of sharing a reproduceable case they fix their issue and call it finished 🤷♂️ I didn't know that with pulse there is a reproduceable case. I'll look into that next week - currently ill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1689
Not sure if we can detect/prevent this though.
Reproducable case: