Fix ErrorException on empty responses #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikn69
reviewed
Sep 23, 2024
| @@ -905,7 +905,7 @@ protected function isJsonRequest(Request $request, Response $response) | |||
|
|
|||
| // Check if content looks like JSON without actually validating | |||
| $content = $response->getContent(); | |||
| if ($content !== false && in_array($content[0], ['{', '['], true)) { | |||
| if ($content && in_array($content[0], ['{', '['], true)) { | |||
There was a problem hiding this comment.
-if ($content && in_array($content[0], ['{', '['], true)) {
+if (is_string($content) && in_array($content[0] ?? '', ['{', '['], true)) {
There was a problem hiding this comment.
-if ($content && in_array($content[0], ['{', '['], true)) {
+if (is_string($content) && json_decode($content) !== null) {I think we should use json_decode because may be json has contains space first or last
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the spatie/laravel-honeypot package returns an empty response if the honeypot field is filled in. In this case, the Laravel Debugbar triggers an ErrorException with the message “Uninitialized string offset 0.”