Skip to content

Commit

Permalink
Fix error message on invalid field names for a struct variant
Browse files Browse the repository at this point in the history
  • Loading branch information
barosl committed Dec 21, 2014
1 parent cc19e33 commit c9010bf
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 10 deletions.
34 changes: 24 additions & 10 deletions src/librustc_typeck/check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3419,7 +3419,8 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>,
substitutions: subst::Substs<'tcx>,
field_types: &[ty::field_ty],
ast_fields: &[ast::Field],
check_completeness: bool) {
check_completeness: bool,
enum_id_opt: Option<ast::DefId>) {
let tcx = fcx.ccx.tcx;

let mut class_field_map = FnvHashMap::new();
Expand All @@ -3438,13 +3439,24 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>,
match pair {
None => {
fcx.type_error_message(
field.ident.span,
|actual| {
format!("structure `{}` has no field named `{}`",
actual, token::get_ident(field.ident.node))
},
struct_ty,
None);
field.ident.span,
|actual| match enum_id_opt {
Some(enum_id) => {
let variant_type = ty::enum_variant_with_id(tcx,
enum_id,
class_id);
format!("struct variant `{}::{}` has no field named `{}`",
actual, variant_type.name.as_str(),
token::get_ident(field.ident.node))
}
None => {
format!("structure `{}` has no field named `{}`",
actual,
token::get_ident(field.ident.node))
}
},
struct_ty,
None);
error_happened = true;
}
Some((_, true)) => {
Expand Down Expand Up @@ -3525,7 +3537,8 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>,
struct_substs,
class_fields.as_slice(),
fields,
base_expr.is_none());
base_expr.is_none(),
None);
if ty::type_is_error(fcx.node_ty(id)) {
struct_type = ty::mk_err();
}
Expand Down Expand Up @@ -3567,7 +3580,8 @@ fn check_expr_with_unifier<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>,
substitutions,
variant_fields.as_slice(),
fields,
true);
true,
Some(enum_id));
fcx.write_ty(id, enum_type);
}

Expand Down
18 changes: 18 additions & 0 deletions src/test/compile-fail/issue-19922.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

enum Homura {
Akemi { madoka: () }
}

fn main() {
let homura = Homura::Akemi { kaname: () };
//~^ ERROR struct variant `Homura::Akemi` has no field named `kaname`
}

1 comment on commit c9010bf

@eddyb
Copy link

@eddyb eddyb commented on c9010bf Dec 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ rollup

Please sign in to comment.