prefix macro VERSION #882
Merged
prefix macro VERSION #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Windows the installation of OpenSSL fails. This has nothing to do with this PR. |
|
Is fixed in main |
cspiel1
force-pushed
the
macro_version_prefix
branch
from
6ca3857 to
36d9ee4
Compare
alfredh
reviewed
Jul 24, 2023
src/http/request.c
Outdated
| #ifndef VERSION | ||
| #define VERSION "???" | ||
| #ifndef RE_VERSION | ||
| #define RE_VERSION "???" |
There was a problem hiding this comment.
The version string is re-defined here ?
There was a problem hiding this comment.
Yes this looks strange, better to include re_sys.h
There was a problem hiding this comment.
Yes, I add a commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids name conflict in zephyr