Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbuf: use float ratio #817

Merged
merged 1 commit into from
Jun 1, 2023
Merged

jbuf: use float ratio #817

merged 1 commit into from
Jun 1, 2023

Conversation

sreimers
Copy link
Member

No description provided.

@sreimers sreimers marked this pull request as ready for review May 20, 2023 10:46
@sreimers sreimers marked this pull request as draft May 21, 2023 08:40
@sreimers sreimers force-pushed the jbuf_float_ratio branch from 1f52cc9 to 340c582 Compare May 21, 2023 08:57
@juha-h
Copy link
Contributor

juha-h commented May 21, 2023

I tested this PR using

        replaceVariable("audio_jitter_buffer_type", "adaptive")
        replaceVariable("audio_jitter_buffer_delay", "0-20")

        replaceVariable("video_jitter_buffer_type", "adaptive")
        replaceVariable("video_jitter_buffer_delay", "1-50")

and didn't have issues with calls. In video calls I got some of these:

05-21 16:57:03.216 28352 28473 D Baresip+ Lib: video: recv Picture Loss Indication (PLI)

but they probably are not related to this PR.

@sreimers
Copy link
Member Author

Thanks for testing.

05-21 16:57:03.216 28352 28473 D Baresip+ Lib: video: recv Picture Loss Indication (PLI)

Are both clients baresip?

@juha-h
Copy link
Contributor

juha-h commented May 22, 2023

Are both clients baresip?

Yes, I have tested both using Debian and Android baresips. I get more of those message when network is slower (mobile vs. local WiFi).

@alfredh
Copy link
Contributor

alfredh commented Jun 1, 2023

please rebase to main, wait for CI, and merge to main ...

@sreimers sreimers force-pushed the jbuf_float_ratio branch from 713eec0 to 92c240f Compare June 1, 2023 08:01
@sreimers sreimers merged commit 6fc4a1d into main Jun 1, 2023
@sreimers sreimers deleted the jbuf_float_ratio branch June 1, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants