Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jbuf: fix possible division by zero #815

Merged
merged 1 commit into from
May 19, 2023
Merged

jbuf: fix possible division by zero #815

merged 1 commit into from
May 19, 2023

Conversation

sreimers
Copy link
Member

No description provided.

@sreimers sreimers force-pushed the jbuf_div_by_zero branch from be3f6e7 to 2e932b5 Compare May 18, 2023 19:24
@sreimers sreimers force-pushed the jbuf_div_by_zero branch from 2e932b5 to 070924f Compare May 18, 2023 19:25
@sreimers sreimers marked this pull request as ready for review May 18, 2023 19:33
@juha-h
Copy link
Contributor

juha-h commented May 19, 2023

I tested the PR and now I was able to hear audio with this config:

05-19 07:30:44.184 15260 15260 I Baresip : audio_buffer_mode adaptive
05-19 07:30:44.184 15260 15260 I Baresip : audio_buffer 20-300
05-19 07:30:44.184 15260 15260 I Baresip : audio_jitter_buffer_type adaptive
05-19 07:30:44.184 15260 15260 I Baresip : audio_jitter_buffer_delay 0-20
05-19 07:30:44.184 15260 15260 I Baresip : video_jitter_buffer_type adaptive
05-19 07:30:44.184 15260 15260 I Baresip : video_jitter_buffer_delay 0-50

But when looking at it, I started to wonder why there doesn't exist video_buffer_mode and video_buffer config variables?

@sreimers
Copy link
Member Author

But when looking at it, I started to wonder why there doesn't exist video_buffer_mode and video_buffer config variables?

Only audio has a separate aubuf (controlled by audio_buffer options), to handle thread safety and realtime requirements:

auplay <-- aubuf <-- aufilt <-- decode <--- jbuf <--- RTP

Video pipeline looks like this:

 vidisp <-- vidfilt <-- decoder <--- jbuf <---  RTP

@sreimers sreimers merged commit ae5f94b into main May 19, 2023
@sreimers sreimers deleted the jbuf_div_by_zero branch May 19, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants