cmake: use BUILD_SHARED_LIBS #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only build shared or static library (not both).
|
I can try this with Vcpkg |
|
this looks good. I tested this patch with Vcpkg and it is working: |
|
I guess for Debian packages we would have to compile it twice, one for shared and one for static ? also another option is to add 2 variables, so it can build both in one go: |
|
Yes I think this looks better and is more flexible: #778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only build shared or static library (not both).
refs #771
Breaking change, for static builds
cmake -B build -DBUILD_SHARED_LIBS=OFFis needed.