fix weak self-signed certificates #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increases the size of the self-signed key/certificate to 2048 bytes. Recent versions of OpenSSL refuse to use certificates with 1024 byte RSA signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increases the size of the self-signed key/certificate to 2048 bytes.
Recent versions of OpenSSL refuse to use certificates with 1024 byte
RSA signatures.
I ran into this after upgrading ubuntu and SSL_CTX_use_certificate returning an error 1.
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_get_security_level.html returns 2 on those systems, forbidding 1024 byte keys. The overall security of self-signed certificates is not great but this helper method is convenient :-)