PRACK refactoring #630
PRACK refactoring #630
Conversation
maximilianfridrich
force-pushed
the
prack_refactoring
branch
2 times, most recently
from
4a6da0c to
fbc6b91
Compare
|
I am quite confused as to why some checks are failing. I rebased and added an additional test to retest. Maybe an issue with the build agent? Could someone trigger a re-check? |
src/sipsess/prack.c
Outdated
| int err; | ||
|
|
||
| if (!req || req->tmr.th) | ||
| return -1; |
There was a problem hiding this comment.
better to return EINVAL here ...
src/sipsess/sess.c
Outdated
| * @return true if session is waiting for a PRACK to a 1xx containing SDP, | ||
| * false otherwise | ||
| */ | ||
| bool sipsess_awaiting_prack(struct sipsess *sess) |
There was a problem hiding this comment.
Thank you. Done.
src/sipsess/sess.c
Outdated
| * | ||
| * @return True if a target refresh is currently allowed, otherwise false | ||
| */ | ||
| bool sipsess_refresh_allowed(struct sipsess *sess) |
There was a problem hiding this comment.
Thank you. Done.
maximilianfridrich
force-pushed
the
prack_refactoring
branch
from
fbc6b91 to
acc21aa
Compare
|
maximilianfridrich
force-pushed
the
prack_refactoring
branch
from
acc21aa to
57465e7
Compare
Sorry, that was a bit careless. My time is somewhat limited currently, but my intention is to fix the retest issue we are seeing. Should we switch this PR and the related ones to draft for the time being? It could be a few days until I have time to look at it again. |
Add awaiting_sdp_prack bool to sipsess to be able to check whether the sipsess is still awaiting a PRACK to a 1xx response with SDP. Further, refactor PRACK logic to remove ht_prack which was unused and unneeded.
maximilianfridrich
force-pushed
the
prack_refactoring
branch
from
57465e7 to
b006031
Compare
|
looks good now. should we merge it to main? |
|
I think @cspiel1 will look at it again later today, so maybe we can give him a little bit of time. The more reviewers the better. |
awaiting_prack boolto sipsess to be able to check whether the sipsess is still awaiting a PRACK to a 1xx response with SDP.Related: