Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update res.c #56

Merged
merged 6 commits into from
Dec 14, 2020
Merged

Update res.c #56

merged 6 commits into from
Dec 14, 2020

Conversation

jurjen-van-dijk
Copy link
Contributor

Properly process IPV4 and IPV6 addresses

@jurjen-van-dijk
Update res.c
7013ee5 
Properly process IPV4 and IPV6 addresses
sreimers
sreimers reviewed Dec 14, 2020
View reviewed changes
src/dns/res.c Outdated Show resolved Hide resolved
src/dns/res.c Outdated Show resolved Hide resolved
@sreimers
Copy link
Member

Thanks for PR. Please see my review comments. And the ccheck errors needs to be fixed:

./src/dns/res.c:56: line is too wide (113 - max 79)
Statistics:
./src/dns/res.c:58: has trailing tab(s)
~~~~~~~~~~~
./src/dns/res.c:61: line is too wide (89 - max 79)

@jurjen-van-dijk
Update res.c
c226e94 
Updated for PR review
@jurjen-van-dijk
Update res.c
7fe1fb8 
fixed ccheck errors
@jurjen-van-dijk
Update res.c
1a01a33 
ccheck fixes
@jurjen-van-dijk
Update res.c
9faf926 
Only include for DARWIN
@jurjen-van-dijk
Revert "Update res.c"
60d0ff2 
This reverts commit 9faf926.
@sreimers sreimers merged commit 06a7aab into baresip:master Dec 14, 2020
@sreimers sreimers added the enhancement New feature or request label Apr 9, 2021
@sreimers sreimers added this to the v2.0.0 milestone Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreimers sreimers sreimers approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jurjen-van-dijk @sreimers