http: fix ptr of conn and request at req_close #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request of the connection must be set to NULL at req_close. Wrong checks in conn_idle would lead to not start the idle_timeout and the request of the connection would not be set to NULL. At TCP connection close, close_handler & try_next is called with ECONNRESET. This would lead to a ptr deref in try_next of conn->req which is valid data, but the req itself is not valid anymore. conn_req is not a NULL ptr so the check if (!req) is not effective. Following the next line, one sets a nonvalid data segment (req->conn) -> SEGV.
sreimers
reviewed
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request of the connection must be set to NULL at req_close.
Wrong checks in conn_idle would lead to not start the idle_timeout
and the request of the connection would not be set to NULL.
At TCP connection close, close_handler & try_next is called with
ECONNRESET. This would lead to a ptr deref in try_next of conn->req
which is valid data, but the req itself is not valid anymore.
conn_req is not a NULL ptr so the check if (!req) is not effective.
Following the next line, one sets a nonvalid data segment (req->conn) -> SEGV.