sip: add RFC 3311 support #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilianfridrich
force-pushed
the
rfc_3311
branch
from
15c261f to
0e27ddb
Compare
maximilianfridrich
force-pushed
the
rfc_3311
branch
2 times, most recently
from
ca3763f to
2f5d5d3
Compare
|
Retest PR opened. Coverage above threshold again. |
maximilianfridrich
force-pushed
the
rfc_3311
branch
3 times, most recently
from
37368a2 to
4a1cb92
Compare
cspiel1
reviewed
Jul 14, 2022
src/sipsess/listen.c
Outdated
| sess->modify_pending = false; | ||
| tmr_cancel(&sess->tmr); | ||
| mem_deref(desc); | ||
| } |
There was a problem hiding this comment.
What is the difference to the reinvite_handler()? Maybe we could avoid some code duplication.
There was a problem hiding this comment.
Combined in 2fb5cf3.
cspiel1
reviewed
Jul 14, 2022
| (void)sipsess_update(sess, true); | ||
| else | ||
| sess->desc = mem_deref(sess->desc); | ||
| } |
There was a problem hiding this comment.
Same here. Maybe code duplication with reinvite_resp_handler() can be avoided. Also it might be more readable with a few if for the differences.
There was a problem hiding this comment.
Combined in 2fb5cf3.
maximilianfridrich
force-pushed
the
rfc_3311
branch
from
93888f9 to
af69d4d
Compare
maximilianfridrich
force-pushed
the
rfc_3311
branch
2 times, most recently
from
42d09e1 to
d3c8334
Compare
If a UAS receives an UPDATE without SDP, it MUST NOT send SDP in the response body. I.e. the target_refresh_handler only calls the offer handler (which sets the SDP) if it has received an INVITE or the request contained an SDP body.
maximilianfridrich
force-pushed
the
rfc_3311
branch
from
d3c8334 to
a8f1a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RFC 3311 - the SIP UPDATE method.
Related: