-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mk: add .so name versioning, resolves #32 #39
Conversation
after building this branch I get:
is it correct that the number after so should be 11 ? |
Yes it's currently My thought was a new Feature release, increments ABI too. but we can also specify a stricter ABI compatibility |
I am not sure about this PR. I guess @robert-scheck should test and review it. I sometimes look at the Opus project for inspiration. Here is similar info
I dont understand why libopus0 has version 1.3 ...? perhaps we should also ask @jonassmedegaard from the Debian project for input. Alfred |
The Debian package containing the runtime library has the major part of the SONAME in its package name and has the 1.3 is version of upstream opus release Hope that helps. |
I updated the PR to count SONAME ABI Version independent and starting with |
After some thought and research, I would prefer this versioning:
This corresponds to semantic versioning. Sorry for the back and forth. But personally I use Libre only as static cross-platform builds The "/usr/lib/libre.so.1 -> libre.so.1.1.0" linking is done by ldconfig (soname field). As https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html |
This text seems to decently clarify the distinction between project versions, APIs and ABIs, in case that's a help to some following along here: https://dcreager.net/shared-library-versions/ |
Ok the author suggest to use a separate ABI shared library version info, the math is the following:
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html Opus uses the following:
|
@robert-scheck Can you check if soname handling fits your needs/requirements?
@alfredh I saw that you added and reverted a similar change some time ago: creytiv/re@1d19127
Are there any problems I should be aware of or i should test?