Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: remove call to openssl init #1120

Merged
merged 1 commit into from
May 16, 2024
Merged

main: remove call to openssl init #1120

merged 1 commit into from
May 16, 2024

Conversation

alfredh
Copy link
Contributor

@alfredh alfredh commented May 15, 2024

No description provided.

@alfredh
Copy link
Contributor Author

alfredh commented May 15, 2024

It looks like openssl is doing automatic init now:

https://www.openssl.org/docs/man3.0/man3/OPENSSL_init_ssl.html

Should we remove this call to openssl_init ?

@sreimers
Copy link
Member

sreimers commented May 15, 2024

Looks good to me (should be supported since openssl 1.1.0), maybe we move the SIGPIPE signal handling to libre_init, so src/main/openssl.c can be removed.

@alfredh
Copy link
Contributor Author

alfredh commented May 16, 2024

okay good. please merge to main.

@sreimers sreimers merged commit 25b1e40 into main May 16, 2024
37 checks passed
@sreimers sreimers deleted the openssl_init branch May 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants