Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix cppcheck warnings #1040

Merged
merged 1 commit into from
Jan 4, 2024
Merged

test: fix cppcheck warnings #1040

merged 1 commit into from
Jan 4, 2024

Conversation

alfredh
Copy link
Contributor

@alfredh alfredh commented Jan 4, 2024

No description provided.

@alfredh
Copy link
Contributor Author

alfredh commented Jan 4, 2024

src/sipevent/sipevent.h:51:39: error: syntax error [syntaxError]
void sipnot_refresh(struct sipnot *not, uint32_t expires);
                                      ^
test/aulength.c:27:3: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]
  TEST_ERR(err);
  ^
test/aulength.c:26:6: note: outer condition: err
 if (err)
     ^
test/aulength.c:27:3: note: identical inner condition: err
  TEST_ERR(err);
  ^
test/httpauth.c:663:9: warning: Uninitialized variable: err [uninitvar]
 return err;
        ^
test/httpauth.c:595:23: note: Assuming condition is false
 for (size_t i = 0; i < RE_ARRAY_SIZE(testv); i++) {
                      ^
test/httpauth.c:663:9: note: Uninitialized variable: err
 return err;
        ^
test/rtp.c:424:9: warning: Identical condition and return expression 'err', return value is always 0 [identicalConditionAfterEarlyExit]
 return err;
        ^
test/rtp.c:417:6: note: If condition 'err' is true, the function will return/exit
 if (err)
     ^
test/rtp.c:424:9: note: Returning identical expression 'err'
 return err;
        ^

@sreimers sreimers merged commit a3991df into main Jan 4, 2024
44 checks passed
@sreimers sreimers deleted the alfredh_cppcheck_fixes branch January 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants