Syv followup constituency first baob only #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added link and UK/ USA cousin disambiguation text and link
This is a combination of 7 commits. HACKING towards constituency first - step 1-6 unsuccessful in getting the hidden field really hidden. I suspect some CSS skills required
Relates to swapmyvote/swapyourvote-usa#24 1. the method prepopulate_fields_from_session was referencing parties before the state had even been defined (part of the api/prepopulate code) 2. the 'pre_login' code that sequences state-then-candidates questions was unecessarily messing with the session parameters associated with api/prepopulate.
the spec should be moved to the page that does the constituency selection
This is a combination of 3 commits. add postcode field to constituency selection BUT NOT WORKING add postcodes helper to home page (now has constituencies form) fixed postcode helper to work on home page
partially addresses comment on commit 3a94e85
now fully addresses comment on commit 3a94e85
This reverts commit ceeb58e. Addresses comment from @stevebaxter here https://github.com/swapmyvote/swapmyvote/pull/1024/files/02f453739b2f0c5b2e2815c29d330cc1464f1034#r1835805752
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| - if !pre_login_constituency_form_complete | ||
| = render partial: "constituency_form", locals: { constituencies: @constituencies, default_constituency_ons_id: @default_constituency_ons_id } | ||
| - else | ||
| = render partial: "candidates_form", locals: { parties: @parties, preferred_party_id: @preferred_party_id, willing_party_id: @willing_party_id, constituency_ons_id: @constituency_ons_id } |
There was a problem hiding this comment.
Avoid using instance variables in partials views
app/views/home/_swap_form.html.haml
Outdated
| cast your preferred vote in a different area where it could count for more. | ||
| In return, you will cast their preferred vote in your area. | ||
| - if !pre_login_constituency_form_complete | ||
| = render partial: "constituency_form", locals: { constituencies: @constituencies, default_constituency_ons_id: @default_constituency_ons_id } |
There was a problem hiding this comment.
Avoid using instance variables in partials views
Revert "disable Rails/I18nLocaleTexts cop" This reverts commit e100814.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really - for testing fixes to swapmyvote#1023 - "Resolve hound complaint about Rails/I18nLocaleTexts found in .rubocop..yml"