Use node IP for advertised.listeners when node port is used #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartam1
changed the title
1 task
panyuenlau
previously approved these changes
Feb 21, 2023
Kuvesz
reviewed
Feb 21, 2023
There was a problem hiding this comment.
Looks good to me, though I'd like to see @panyuenlau 's suggestions before approving.
panyuenlau
previously approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thanks for taking it over from the community.
Should we also update this banzaicloud_v1beta1_kafkacluster.yaml to reflect the new changes on the KafkaCluster changes? And perhaps the node port section in the koperator docs as well
panyuenlau
reviewed
Feb 27, 2023
Kuvesz
previously approved these changes
Feb 28, 2023
1 task
Kuvesz
reviewed
Feb 28, 2023
api/v1beta1/kafkacluster_types.go
Outdated
Comment on lines
197
to
203
| // When "hostNameOverride" and brokerConfig.nodePortExternalIP are empty and NodePort access method is selected for an external listener | ||
| // the NodePortNodeAdddressType defines the Kafka broker's Kubernetes node's address type that shall be used in the advertised.listeners property. | ||
| // https://kubernetes.io/docs/concepts/architecture/nodes/#addresses | ||
| // The NodePortNodeAddressType's values can be Hostname, ExternalIP, InternalIP, InternalDNS,ExternalDNS | ||
| // +kubebuilder:validation:Enum=Hostname;ExternalIP;InternalIP;InternalDNS;ExternalDNS | ||
| // +optional | ||
| NodePortNodeAddressType corev1.NodeAddressType `json:"nodePortNodeAddressType,omitempty"` |
Kuvesz
previously approved these changes
Mar 1, 2023
panyuenlau
reviewed
Mar 1, 2023
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/banzaicloud/koperator | |||
|
|
|||
| go 1.19 | |||
| go 1.18 | |||
Kuvesz
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Using node ip based on configuration (NodePortNodeAddressType) for brokers in advertised.listeners when hostnameOverride and nodePortExternalIP are not set
Why?
Users dont have to specify the node external addresses by hand for the brokers when nodeport is used.
Checklist