Configurable webhook target port #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pregnor
approved these changes
Nov 22, 2022
bartam1
previously approved these changes
Nov 22, 2022
pregnor
requested changes
Nov 22, 2022
hi-im-aren
requested changes
Nov 22, 2022
|
|
balassai
force-pushed
the
webhook-helm
branch
2 times, most recently
from
2bf5fda to
b00dddf
Compare
balassai
force-pushed
the
webhook-helm
branch
from
b00dddf to
9524c4d
Compare
akatona84
approved these changes
Nov 23, 2022
hi-im-aren
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Set the configured webhook port from the values.yaml explicitly on the operator's service.
Why?
When the user wants to use custom webhook port and change the KafkaCluster resource the ValidatingWebhookConfiguration call fails.
Checklist