Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description in helm chart about cert-manager namespace #868

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Add description in helm chart about cert-manager namespace #868

merged 3 commits into from
Sep 26, 2022

Conversation

bartam1
Copy link
Contributor

@bartam1 bartam1 commented Sep 25, 2022 •
edited
Loading

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Cert-manager related comments are added to the helm chart.
Rename a variable from certManagerNamespace to certManagerEnabled

Why?

  • The cert manager namespace should point to the Cert manager's Cluster Resource Namespace for the proper working of the ClusterIssuer
  • When cert manager is used, Its Cluster Resource Namespace is needed to be watched by Koeprator.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@bartam1 bartam1 requested a review from a team as a code owner September 25, 2022 15:17
@bartam1 bartam1 changed the title Fix helm chart cert-manager enabled flag Add description in helm chart about cert-manager namespace Sep 25, 2022
pregnor
pregnor approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartam1 bartam1 merged commit 2317b2d into master Sep 26, 2022
@bartam1 bartam1 deleted the fixcertmanagermiss branch September 26, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyuenlau panyuenlau panyuenlau approved these changes

@pregnor pregnor pregnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartam1 @pregnor @panyuenlau