Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow exposing custom ports for kafka brokers #897

Closed
david-simon opened this issue Nov 22, 2022 · 3 comments
Closed

Allow exposing custom ports for kafka brokers #897

david-simon opened this issue Nov 22, 2022 · 3 comments
Labels
community enhancement New feature or request

Comments

@david-simon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I have a custom kafka distribution that has an integrated metrics exporter service exposed as a HTTP service. I would like to have this port added to the container and the service specs.

Describe the solution you'd like to see
I would like to have a new field added to the CRD (probably with the corev1.ContainerPort type) that will be used to create the kafka containers and services

Describe alternatives you've considered
I tried adding an additional container that would proxy requests to the metrics api but then I have to also create a new service for each broker that exposes this port. This is not ideal since then I have to monitor the number of kafka brokers and adjust the services accordingly.
@hi-im-aren hi-im-aren added enhancement New feature or request community labels Nov 22, 2022
@hi-im-aren
Copy link
Member

hi-im-aren commented Nov 22, 2022 •
edited
Loading

Hi @david-simon thanks for using koperator!

This seems like a good first issue so maybe you could contribute this to the project?

Also, could you think of some other scenarios where you think this could be useful for others as well?
The only thing that comes to my mind is some kind of remote debug port that can use this feature to expose it.

@david-simon
Copy link
Contributor Author

Hi @hi-im-aren
Sorry, forgot to mention in the description that I'm already working on this :)

I'll get back to you with some more use cases if I can

david-simon added a commit to david-simon/koperator that referenced this issue Nov 23, 2022
@david-simon
Add ability to specify additional container ports for kafka clusters (b…
1839912 
…anzaicloud#897)
@david-simon david-simon mentioned this issue Nov 23, 2022
Merged
1 task
hi-im-aren pushed a commit to david-simon/koperator that referenced this issue Nov 28, 2022
@david-simon @hi-im-aren
Add ability to specify additional container ports for kafka clusters (b…
7724bca 
…anzaicloud#897)
pregnor pushed a commit that referenced this issue Nov 30, 2022
@david-simon
Add ability to specify additional container ports for kafka clusters (#…
49c1079 
…897) (#898)

* Add ability to specify additional container ports for kafka clusters (#897)

* fix lint issue

* add example
@david-simon
Copy link
Contributor Author

Resolved in #898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@david-simon @hi-im-aren