Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero as null pointer constant warning #41

Conversation

MartinDelille
Copy link
Contributor

This PR simply replace 0 or NULL by nullptr. It allow compiling the code with the following compiler flags:

-Werror -Wzero-as-null-pointer-constant

@MartinDelille
Copy link
Contributor Author

Ok it fails because I made my modification from the version tagged by the current https://github.com/banditcpp/bandit master branch.

What do you prefer me to do?

  • Push a new PR against the currrent master branch?
  • Create a PR against another branch?

@MartinDelille MartinDelille force-pushed the fix-zero-as-null-pointer-constant-warning branch from e5b8023 to 59f6431 Compare June 9, 2019 17:09
@MartinDelille
Copy link
Contributor Author

Ok I repushed my commit against the current master branch.

@sbeyer
Copy link
Member

sbeyer commented Jun 10, 2019

Thank you very much.

Yes, please always use the master branch for changes. Please amend your commit, so that I can merge. I will then update the headers-only branch which is used by bandit, and you can then update your bandit PR.

@MartinDelille MartinDelille force-pushed the fix-zero-as-null-pointer-constant-warning branch from 59f6431 to 37f0f38 Compare June 10, 2019 14:51
@sbeyer sbeyer merged commit ad130f8 into banditcpp:master Jun 10, 2019
@MartinDelille MartinDelille deleted the fix-zero-as-null-pointer-constant-warning branch June 10, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants