Skip to content

Commit

Permalink
[8.9] [Security Solution] [Detection Engine] Fix exception comment fl…
Browse files Browse the repository at this point in the history
…akiness (elastic#162807) (elastic#164621)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] [Detection Engine] Fix exception comment
flakiness (elastic#162807)](elastic#162807)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Wafaa
Nasr","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-01T13:58:40Z","message":"[Security
Solution] [Detection Engine] Fix exception comment flakiness
(elastic#162807)\n\n## Summary\r\n\r\n- Addresses
elastic#162565 \r\n- Converting the
`Comments` related Cypress test to a FTR test according\r\nto
these\r\n[observations](https://github.com/elastic/kibana/issues/162565#issuecomment-1653410937)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a2275dd346b027db0224e7afa5df58158eb9b641","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["WIP","release_note:skip","test-failure-flaky","Team:Detection
Engine","v8.10.0","v8.9.2"],"number":162807,"url":"https://github.com/elastic/kibana/pull/162807","mergeCommit":{"message":"[Security
Solution] [Detection Engine] Fix exception comment flakiness
(elastic#162807)\n\n## Summary\r\n\r\n- Addresses
elastic#162565 \r\n- Converting the
`Comments` related Cypress test to a FTR test according\r\nto
these\r\n[observations](https://github.com/elastic/kibana/issues/162565#issuecomment-1653410937)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a2275dd346b027db0224e7afa5df58158eb9b641"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162807","number":162807,"mergeCommit":{"message":"[Security
Solution] [Detection Engine] Fix exception comment flakiness
(elastic#162807)\n\n## Summary\r\n\r\n- Addresses
elastic#162565 \r\n- Converting the
`Comments` related Cypress test to a FTR test according\r\nto
these\r\n[observations](https://github.com/elastic/kibana/issues/162565#issuecomment-1653410937)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a2275dd346b027db0224e7afa5df58158eb9b641"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
  • Loading branch information
WafaaNasr authored Aug 24, 2023
1 parent 4c62619 commit 63985f2
Show file tree
Hide file tree
Showing 4 changed files with 302 additions and 307 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type { CreateExceptionListSchema } from '@kbn/securitysolution-io-ts-list

import {
DESCRIPTION,
DETECTION_TYPE,
ENDPOINT_TYPE,
LIST_ID,
META,
Expand Down Expand Up @@ -55,5 +56,5 @@ export const getCreateExceptionListDetectionSchemaMock = (): CreateExceptionList
description: DESCRIPTION,
list_id: LIST_ID,
name: NAME,
type: 'detection',
type: DETECTION_TYPE,
});

This file was deleted.

Loading

0 comments on commit 63985f2

Please sign in to comment.