Telos Updated #659
Open
Telos Updated #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakman
requested changes
May 20, 2024
fastlane_bot/helpers/txhelpers.py
Outdated
| if self.cfg.SUPPORTS_EIP1559: | ||
| gas_cost_wei = tx["gas"] * tx["maxFeePerGas"] | ||
| else: | ||
| gas_cost_wei = tx["gas"] |
There was a problem hiding this comment.
Need to multiply by tx["gasPrice"]
| } | ||
| else: | ||
| return { | ||
| "value": value, |
There was a problem hiding this comment.
Missing type (0 or 1, need to find out with Telos which one is supported)
There was a problem hiding this comment.
Actually not.
When passing type as 1: ValueError: {'message': 'Invalid Transaction: Calling from_big_endian with oversized array', 'code': 3}
When passing type as 0: TypeError: Unknown Transaction type: 0
When passing nothing as I have it, the arb executes immediately
platonfloria
force-pushed
the
sei-release-candidate
branch
from
62cd989 to
9f56e92
Compare
platonfloria
force-pushed
the
sei-release-candidate-telos
branch
from
3ff0ab1 to
db253d3
Compare
zavelevsky
force-pushed
the
sei-release-candidate
branch
from
9f56e92 to
7444e5e
Compare
platonfloria
force-pushed
the
sei-release-candidate-telos
branch
from
db253d3 to
98f6105
Compare
NIXBNT
force-pushed
the
sei-release-candidate-telos
branch
from
4513ef9 to
ceeb146
Compare
platonfloria
force-pushed
the
sei-release-candidate-telos
branch
from
ceeb146 to
0fdf364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_telosbranch rebased onto thesei-release-candidateA few things changed that need checking and considering:
Terraformer works with eth_logs.
Test transaction successful using legacy transaction